Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: migrate packages to by-name hierarchy #254417

Merged
merged 20 commits into from
Oct 12, 2023
Merged

treewide: migrate packages to by-name hierarchy #254417

merged 20 commits into from
Oct 12, 2023

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Sep 10, 2023

Description of changes

The ones maintained by @AndersonTorres

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 10, 2023
@AndersonTorres AndersonTorres marked this pull request as ready for review September 11, 2023 04:21
@mohe2015
Copy link
Contributor

I think it was discussed at NixCon that we should move to the new schema using automation (where possible) to avoid the overhead of many PRs. You also did some cleanup so in this case this is probably fine.

@AndersonTorres
Copy link
Member Author

AndersonTorres commented Sep 11, 2023

This is an opportunity to review my own code and not lose some tracks. I have found some packages that should be removed and others needing more attention, like TLOE.

Also there is no problem in some manual intervention.

@AndersonTorres
Copy link
Member Author

@ofborg build pkgsLLVM.mksh mksh

@infinisil
Copy link
Member

Yeah so I will work on updating #211832 next, which is the automated mass migration. I wouldn't want people to have to do this manually to save on both reviewer and contributor time.

I think it's fine if you happen to clean up the code or update the versions anyways though. Since you did the work here already I guess it's fine, but others should definitely not be encouraged to do this manually until the automated migration is done (it doesn't work automatically for all packages) 🙂

@infinisil
Copy link
Member

I opened #254632 to have this written down

@AndersonTorres
Copy link
Member Author

OK, I will stop this thread for now and concentrate in the version bumps.

@AndersonTorres
Copy link
Member Author

@ofborg build xorriso dosbox-staging

@ofborg ofborg bot requested a review from konimex September 12, 2023 01:51
@infinisil
Copy link
Member

Are you intending on having this reviewed and merged after all? Or are you using this as a testing ground before splitting it into smaller cleanup PRs? If so this should probably be turned into a draft.

@AndersonTorres AndersonTorres marked this pull request as draft September 12, 2023 10:04
@AndersonTorres
Copy link
Member Author

Both

@AndersonTorres AndersonTorres merged commit fcf47b6 into NixOS:master Oct 12, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants